Re: Revert "gro: Fix legacy path napi_complete crash",

From: Ingo Molnar
Date: Wed Mar 25 2009 - 05:35:53 EST



* Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Mar 24, 2009 at 02:36:22PM -0700, David Miller wrote:
> >
> > I think the problem is that we need to do the GRO flush before the
> > list delete and clearing the NAPI_STATE_SCHED bit.
>
> Well first of all GRO shouldn't even be on in Ingo's case, unless
> he enabled it by hand with ethtool. [...]

i didnt. (But it's randconfig - so please have a good look at all
.config details - maybe something has an unexpected side-effect?)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/