Re: [PATCH 05/13] [s390] changed ioctls to unlocked

[Heiko Carstens]

On Tue, 24 Mar 2009 16:12:40 -0500
stoyboyker@xxxxxxxxx wrote:

> From: Stoyan Gaydarov <stoyboyker@xxxxxxxxx>
> 
> Signed-off-by: Stoyan Gaydarov <stoyboyker@xxxxxxxxx>
> ---
>  drivers/s390/char/tape_char.c  |   47 +++++++++++++++++++++++----------
>  drivers/s390/char/vmwatchdog.c |   57 ++++++++++++++++++++++++++--------------
>  2 files changed, 70 insertions(+), 34 deletions(-)

Please resend with the comments that Jonathan made for your other
patches: first define variables then lock_kernel() and also please use
gotos.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/