Re: [PATCH 1/5][RFC] tracing: add function profiler

From: Steven Rostedt
Date: Wed Mar 25 2009 - 15:31:41 EST



On Wed, 25 Mar 2009, Frederic Weisbecker wrote:
> > +
> > +static const struct file_operations ftrace_profile_fops = {
> > + .open = tracing_open_generic,
> > + .read = ftrace_profile_read,
> > + .write = ftrace_profile_write,
> > +};
>
>
> I should really provide such helper per stat tracer.
>
> Say, something like:
>
> /debug/tracing/trace_stat/name/enable
>

No, because if you notice in the later patches, I add a per cpu tracing.
This is standard operations, and adding too much will unnecessarily limit
what we can do.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/