Re: [PATCH] x86: don't compile vsmp_64 for 32bit

From: Jeremy Fitzhardinge
Date: Wed Mar 25 2009 - 19:16:06 EST


Ravikiran G Thirumalai wrote:
On Wed, Mar 25, 2009 at 03:16:14PM -0700, Jeremy Fitzhardinge wrote:
Ravikiran G Thirumalai wrote:
It is already there, and has been there! But we still need to make
vsmp64.c compile only when CONFIG_X86_64 is defined no?
I still think you should restructure it so that vsmp_64.c only gets compiled with CONFIG_X86_VSMP enabled. Having all that stuff compiled into every kernel seems pretty pointless.


Well, not everything gets compiled in. Only the is_vsmp_box() logic and
related stuff gets compiled in. Other paravirt related stuff in vsmp64.c
depends on CONFIG_PARAVIRT.

Sure, but it would be cleaner if the whole file were controlled by CONFIG_X86_VSMP. is_vsmp_box() is already defined as const inline returning 0 if !CONFIG_X86_VSMP.

J
Thanks,
Kiran

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/