Re: [PATCH] bonding: allow bond in mode balance-alb to work properlyin bridge -try4

[Patrick McHardy]

David Miller wrote:
> From: Jiri Pirko <jpirko@xxxxxxxxxx>
> Date: Thu, 26 Mar 2009 16:52:06 +0100
>
> > (resend, updated changelog, hook moved into skb_bond_should_drop,
> > skb_bond_should_drop ifdefed)
> >
> > Hi all.
> >
> > The problem is described in following bugzilla:
> > https://bugzilla.redhat.com/show_bug.cgi?id=487763
>  ...
> > This patch solves the situation in the bonding without touching bridge code,
> > as Patrick suggested. For every incoming frame to bonding it searches the
> > destination address in slaves list and if any of slave addresses matches, it
> > rewrites the address in frame by the adress of bonding master. This ensures that
> > all frames comming thru the bonding in alb mode have the same address.
> >
> > Signed-off-by: Jiri Pirko <jpirko@xxxxxxxxxx>
>
>
> I don't like the hook, but if that's how it's best done....
>
> Patrick, please review this.

Me neither, but I don't think this approach can be done without the
hook. While I still find it questionable whether this mode really
needs to be supported for a bridge at all, an alternative approach
would be to have bonding add FDB entries for all secondary MACs to
make bridging treat them as local.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/