Re: [GIT PULL] Microblaze initial pack

From: Michal Simek
Date: Fri Mar 27 2009 - 07:26:35 EST


Ingo Molnar wrote:
> * Ingo Molnar <mingo@xxxxxxx> wrote:
>
>
>> I have noticed one relatively big (but easily fixable) commit
>> structure problem in this tree.
>>
>> All of the commits have these tags:
>>
>> Reviewed-by: Stephen Neuendorffer <stephen.neuendorffer@xxxxxxxxxx>
>> Acked-by: John Linn <john.linn@xxxxxxxxxx>
>> Acked-by: John Williams<john.williams@xxxxxxxxxxxxx>
>>
>
> I forgot to mention that in any case _your_ signoff as the submitter
> of this tree should be in all commits as well.
>
> So for example this (sample) chain would be fine:
>
> Reviewed-by: Stephen Neuendorffer <stephen.neuendorffer@xxxxxxxxxx>
> Acked-by: John Linn <john.linn@xxxxxxxxxx>
> Acked-by: John Williams<john.williams@xxxxxxxxxxxxx>
> Signed-off-by: Michal Simek <monstr@xxxxxxxxx>
>
> It's not enough to be listed as the author in the commit. (In any
> case please see Documentation/SubmittingPatches and the DCO 1.1.)
>
I add my name there too.

> Also, a minor stylistic detail, please fix this:
>
> John Williams<john.williams@xxxxxxxxxxxxx>
>
> to:
>
> John Williams <john.williams@xxxxxxxxxxxxx>
>
I fixed that space problem.

Thanks,
Michal
> Thanks,
>
> Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arch" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>


--
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/