RE: [patch 4/14] x86, ds: wait before freeing the DS configuration

From: Metzger, Markus T
Date: Fri Mar 27 2009 - 11:39:55 EST


>-----Original Message-----
>From: Oleg Nesterov [mailto:oleg@xxxxxxxxxx]
>Sent: Friday, March 27, 2009 3:36 PM
>To: Metzger, Markus T
>Cc: linux-kernel@xxxxxxxxxxxxxxx; mingo@xxxxxxx; tglx@xxxxxxxxxxxxx; hpa@xxxxxxxxx;
>markus.t.metzger@xxxxxxxxx; roland@xxxxxxxxxx; eranian@xxxxxxxxxxxxxx; Villacis, Juan;
>ak@xxxxxxxxxxxxxxxxxx
>Subject: Re: [patch 4/14] x86, ds: wait before freeing the DS configuration
>
>On 03/27, Markus Metzger wrote:
>>
>> --- git-tip.orig/arch/x86/kernel/ds.c 2009-03-27 07:59:23.000000000 +0100
>> +++ git-tip/arch/x86/kernel/ds.c 2009-03-27 08:00:41.000000000 +0100
>> @@ -783,6 +783,14 @@ void ds_release_bts(struct bts_tracer *t
>>
>> ds_suspend_bts(tracer);
>>
>> + /*
>> + * We must wait for the suspend to take effect before we may
>> + * free the tracer and the ds configuration.
>> + */
>> + if (tracer->ds.context->task &&
>> + (tracer->ds.context->task != current))
>> + wait_task_inactive(tracer->ds.context->task, 0);
>> +
>
>Since you didn't replay yet, I will just repeat my question ;)

I replied in http://lkml.org/lkml/2009/3/27/220.

regards,
markus.

---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/