Re: [PATCH 04/58] move at91_ether's probe function to .devinit.text

From: David Brownell
Date: Fri Mar 27 2009 - 20:09:53 EST


On Friday 27 March 2009, Uwe Kleine-König wrote:
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.

IMO that's preferable for this driver. There's no
point in doing anything other than discarding the
probe() method after the driver has been set up;
it'd be doing nothing except wasting memory.

Same thing for ... pretty much all other drivers
for SoC platform devices.

In this series, you cc'd me on four OMAP drivers
(mmci-omap, mmci-omap-hs, omap-rng, omap_udc) which
I *know* that's a completely workable -- and far
preferable -- solution. There might be others.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/