Re: [PATCH -tip 3/4 V3] tracing: kprobe-tracer plugin supportsarguments

From: Ananth N Mavinakayanahalli
Date: Mon Mar 30 2009 - 00:58:29 EST


On Thu, Mar 26, 2009 at 06:59:30PM -0400, Masami Hiramatsu wrote:

> +/* TODO: Move these functions to arch/XXX/include/asm/debugger.h */
> +

Maybe arch/xxx/lib/<>.c too?

I know its on your list of TODOs but I'd prefer to have an
arch_fetch_func_args() or somesuch in arch specific code, to start with.
It is trivial to implement the argument extraction code on certain
architectures and such a helper would be great.

Ananth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/