Re: [PATCH -tip 3/3] x86, mce: Add mce=nopoll option to disable timerpolling

[Andi Kleen]

Hidetoshi Seto wrote:
> Andi Kleen wrote:
>>>> Also I'm not sure a boot argument is really needed. Isn't it
>>>> good enough to do this early at boot through sysfs?
>>> Maybe it is good for this option, as far as polling never run
>>> so soon.  Because sysfs is available after start of polling
>>> timer, boot argument is required just in theory of logics.
>> I think the best way would be to just not run mcelog if you want
>> the BIOS to log all. The only problem I guess is that users might be confused
>> by the printk. So perhaps just do a patch to shut down the printk?
> 
> How to prevent banks from clearing?

Firmware first typically means the firmware gets it one way or another
using SMI and that tends to work even when the OS clears because
SMI comes first. So stopping the clearing is probably not needed?

>>> One another problem is that there are multiple documentations for
>>> machinecheck parameters, but not linked well:
>>>
>>>  - Documentation/kernel-parameters.txt
>>>     ("See Documentation/x86/x86_64/boot-options.txt" for "mce=")
>>>  - Documentation/x86/x86_64/boot-options.txt
>>>     ("AMD64 specific boot options" is not true now!)
>>>  - Documentation/x86/x86_64/machinecheck
>>>     (which I had not noticed the existence at first, oops!)
>> machinecheck is for the sysfs interface, boot options is for the boot parameters.
>>
>> I guess a reference could be added to machinecheck to point to boot-options.txt
> 
> Vice verse, I suppose.
> boot-options.txt just have "Everything else is in sysfs now." without pointing
> machinecheck that describe the sysfs well.

I added a reference in my pile.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/