Re: compilation error in linus git tree

From: Frederic Weisbecker
Date: Mon Mar 30 2009 - 12:16:24 EST


Hi,


On Mon, Mar 30, 2009 at 12:01:59PM -0400, Peter Teoh wrote:
> just git pulled and compiled with the following errors:
>
> CC [M] arch/x86/kernel/cpu/cpufreq/speedstep-lib.o
> CC [M] arch/x86/kernel/cpu/cpufreq/p4-clockmod.o
> arch/x86/kernel/cpu/cpufreq/p4-clockmod.c: In function âcpufreq_p4_cpu_initâ:
> arch/x86/kernel/cpu/cpufreq/p4-clockmod.c:232: error: implicit
> declaration of function ârecalibrate_cpu_khzâ
> make[3]: *** [arch/x86/kernel/cpu/cpufreq/p4-clockmod.o] Error 1
> make[2]: *** [arch/x86/kernel/cpu/cpufreq] Error 2
> make[1]: *** [arch/x86/kernel/cpu] Error 2
> make: *** [arch/x86/kernel] Error 2
>
> not sure where is the best place to put this, but the error is resolved via
>
> extern int recalibrate_cpu_khz(void);
>
> inside the file:
>
> arch/x86/kernel/cpu/cpufreq/p4-clockmod.c


Indeed but its prototype is already defined in asm/timer.h
This is a missing include, can you tell me if the patch below fixes
your problem?

Thanks,
Frederic.


--