Re: [PATCH] proc 1/6: implement support for automounts in task directories

[Eric W. Biederman]

Alexey Dobriyan <adobriyan@xxxxxxxxx> writes:

> I don't have a lot of opinion on this bug. I checked patchset to fix known
> reproducer, timeout is obviously taken out of air and not nice.

As for timeout.  The logic is that mark_mounts_for_expiry is just an
aging mechanism, and if something is actually in use it is not aged out.

In the general case the call to proc_shrink_automounts in
kernel/exit.c will clean up everything.  It is possible but unlikely
in practice that someone will pin a lot of process directories open
then stop pinning them, and after that point nothing will remain open,
so we close that hole.

I set timeout huge because it should never be needed in real life.

That said I'm up for taking this as a starting point and generalizing
the mechanisms in fs/namespace.c.  So I don't need a timeout at all,
but that is an orthogonal discussion.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/