Re: [PATCH] ext4: fix blkdev_issue_flush() failure handling

[Fernando Luis Vázquez Cao]

Theodore Tso wrote:
> On Mon, Mar 30, 2009 at 10:01:16PM +0900, Fernando Luis Vázquez Cao wrote:
> > Chris, I have just sent patches that attempt to fix both ext3 and
> > ext4 while also adding a per-device sysfs knob tu disable
> > write-flushes. A previous version of this patch set added a new
> > generic mount option but comments from Christoph and others
> > convinced me to turn it into a per-device tunable. Could you take
> > a look at the patches?
>
> Fernando, see my comments on those patches.  We don't need to issue a
> barrier after a call to sync_inode() or ext[34]_force_commit(), since
> those functions will issue a barrier for us.  It would probably be a
> good idea to use blktrace to test and make sure that we have one and
> exactly one barrier op issued for each fsync().

I'll give blktrace a spin and check if things are working as expected.

Thanks!

- Fernando
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/