Re: [PATCH] : Code cleanup for fs/inode.c as per checkpatch.pl

[Al Viro]

On Tue, Mar 31, 2009 at 02:32:37PM +0530, Manish Katiyar wrote:

> -static struct inode * find_inode(struct super_block * sb, struct hlist_head *head, int (*test)(struct inode *, void *), void *data)
> +static struct inode *find_inode(struct super_block *sb, struct hlist_head *head,
> +				int (*test)(struct inode *, void *), void *data)

If you are splitting it, split it all the way, esp. the last line.

> -static struct inode * get_new_inode(struct super_block *sb, struct hlist_head *head, int (*test)(struct inode *, void *), int (*set)(struct inode *, void *), void *data)
> +static struct inode *get_new_inode(struct super_block *sb,
> +				struct hlist_head *head,
> +				int (*test)(struct inode *, void *),
> +				int (*set)(struct inode *, void *), void *data)

Ditto, and that's even more serious case - here 'void *data' part is
really obfuscated.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/