Re: [PATCH 13/15] perf_counter: provide generic callchain bits

[Paul Mackerras]

Peter Zijlstra writes:

> That still has the record and read things separate, but as one unified
> overflow output.

I take it PERF_EVENT_OVERFLOW refers to counter overflow, not ring
buffer overflow?  That had me confused for a bit, so more explicit
naming, or at least some comments, would be good.

>  /*
> + * Bits that can be set in hw_event.record_type to request information
> + * in the overflow packets.
> + */
> +enum perf_counter_record_format {
> +	PERF_RECORD_IP		= 1U << 0,
> +	PERF_RECORD_TID		= 1U << 1,
> +	PERF_RECORD_GROUP	= 1U << 2,
> +	PERF_RECORD_CALLCHAIN	= 1U << 3,
> +};
[snip]
>  enum perf_event_type {
>  
> -	PERF_EVENT_GROUP	= 1,
> -
> -	PERF_EVENT_MMAP		= 2,
> -	PERF_EVENT_MUNMAP	= 3,
> +	PERF_EVENT_MMAP		= 1,
> +	PERF_EVENT_MUNMAP	= 2,
>  
>  	PERF_EVENT_OVERFLOW	= 1UL << 31,
>  	__PERF_EVENT_IP		= 1UL << 30,
>  	__PERF_EVENT_TID	= 1UL << 29,
> -	__PERF_EVENT_CALLCHAIN  = 1UL << 28,
> +	__PERF_EVENT_GROUP	= 1UL << 28,
> +	__PERF_EVENT_CALLCHAIN  = 1UL << 27,

Could we use the same value (and even the same name) for
PERF_RECORD_IP/__PERF_EVENT_IP, PERF_RECORD_TID/__PERF_EVENT_TID,
etc.?

Also, I haven't looked at the callchain stuff much, but does the
callchain info contain a recognizable end delimiter?  At present the
callchain comes last, but if we add more output elements they'll
presumably go after it, so working out where the callchain ends may
become tricky if we're not careful.

Also, let's add PERF_RECORD/PERF_EVENT bits for:

* EVENT_INSTR_ADDR
* EVENT_DATA_ADDR
* EVENT_INSTR_FLAGS
* EVENT_CPU_FLAGS	(so we can distinguish hypervisor/kernel/user)

We would have to call into arch code to get the values for these.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/