Re: [PATCH 4/5] IPMI: Add console oops catcher

[Andrew Morton]

On Tue, 03 Mar 2009 16:03:37 -0800
Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx> wrote:

> ...
> > This reader is unable to determine what the mystery preempt_disable()
> > is here for.  It needs a comment, please.
> 
> I cannot recall why it's here. So a comment is really needed.
> This preempt_disable() may not be needed.
> 
> > What happens if two CPUs oops at the same time (which is fairly common)?
> 
> ...
>
> OK. I'll look at this.
> 
> > It would be prudent to have a timeout in this loop.  The machine has
> > crashed and subsystems and hardware and memory are in an unknown and
> > possibly bad state.
> 
> Right.
>
> ...
> 
> > This looks like we're abusing the "unblank" method.
> > 
> > If you think that the console subsystem is missing some capability
> > which this driver needs then please do prefer to fix the console
> > subsystem, rather than awkwardly making things fit.
> 
> OK. Will take a look about this point.
> 

None of this happened.

It makes me reluctant to merge that patches as they stand, because then
it all gets forgotten about, whereas holding the patches back will
remind us that updates are needed.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/