Re: [PATCH 1/4] CacheFiles: Use the ->write() file op rather thana special kernel aop

[Christoph Hellwig]

On Fri, Apr 03, 2009 at 10:41:38AM +0100, David Howells wrote:
> +			if (!aops->bmap)
>  				goto check_error;

What are you doing using bmap?  You really shouldn't call into it from
anywhere but FIBMAP.  Yes, swap currently does but it's a major pain
in the neck and Peter has been working on a proper interface for swap
for a while.

> +	if (IS_ERR(file)) {
> +		ret = PTR_ERR(file);

		goto out_something;

> +	} else {
> +		ret = -EIO;
> +		if (file->f_op->write) {

	if (!file->f_op->write)
		goto out_fput;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/