Re: [PATCH 4/4] add ksm kernel shared memory driver.

[Izik Eidus]

Andrey Panin wrote:
> On 094, 04 04, 2009 at 05:35:22PM +0300, Izik Eidus wrote:
>
> <SNIP>
>
>   
> > +static inline u32 calc_checksum(struct page *page)
> > +{
> > +	u32 checksum;
> > +	void *addr = kmap_atomic(page, KM_USER0);
> > +	checksum = jhash(addr, PAGE_SIZE, 17);
> >     
>
> Why jhash2() is not used here ? It's faster and leads to smaller code size.
>   

Beacuse i didnt know, i will check that and change.

Thanks.

(We should really use in cpu crc for Intel Nehalem, and dirty bit for 
the rest of the architactures...)

>   
> > +	kunmap_atomic(addr, KM_USER0);
> > +	return checksum;
> > +}
> >     
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/