Re: [PATCH] rtc-ds1553: Drop IRQF_DISABLED

From: Atsushi Nemoto
Date: Tue Apr 07 2009 - 08:49:28 EST


On Mon, 06 Apr 2009 21:33:42 +0200, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > IRQF_DISABLED should be be used with IRQF_SHARED. Drop IRQF_DISABLED
> > and add spin_lock_irqsave/spin_unlock_irqrestore to the interrupt
> > handler.
>
> I think you should use IRQF_DISABLED if at all possible. Only broken
> hardware has an excuse not to.
>
> NAK

OK, then I will drop IRQF_SHARED instead. There is no in-tree user of
this driver and only out-of-tree user I know uses dedicated irq line
for this RTC.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/