Re: [PATCH]kernel/sched_fair.c: the comment of thecalc_delta_fair() maybe not correctly

[AmÃrico Wang]

On Tue, Apr 07, 2009 at 02:33:06PM +0800, figo.zhang wrote:
>the comment of the calc_delta_fair() maybe not correctly, should be
>delta *= NICE_O_LOAD/se->load
>
>Signed-off-by: figo.zhang <figo.zhang@xxxxxxxxxxxxx>

Agreed.

But...


>
>diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
>index 3816f21..5134b45 100644
>--- a/kernel/sched_fair.c
>+++ b/kernel/sched_fair.c
>@@ -386,7 +386,7 @@ int sched_nr_latency_handler(struct ctl_table
>*table, int write, #endif
> 
> /*
>- * delta /= w
>+ * delta *= NICE_O_LOAD/se->load

Is that an 'O' or '0'(zero)? It looks like an 'O' for me ...
Obviously, it should be '0' (zero). :)


>  */
> static inline unsigned long
> calc_delta_fair(unsigned long delta, struct sched_entity *se)
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@xxxxxxxxxxxxxxx
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Do what you love, f**k the rest! F**k the regulations!
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/