Re: [-rc1, build bug] Re: [PATCH 05/11] Add support for the MAX3100SPI UART.

[Yang Hongyang]

Ingo Molnar wrote:
> * Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> 
>> From: Christian Pellegrin <chripell@xxxxxxxxx>
>>
>> (akpm: queued pending confirmation of the new major number)
>>
>> [randy.dunlap@xxxxxxxxxx: select SERIAL_CORE]
>> Signed-off-by: Christian Pellegrin <chripell@xxxxxxxx>
>> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
>> ---
>>
>>  drivers/serial/Kconfig      |    7 +++++++
>>  drivers/serial/Makefile     |    1 +
>>  include/linux/serial_core.h |    3 +++
>>  3 files changed, 11 insertions(+), 0 deletions(-)
> 
> This is now upstream as:
> 
>   1dcb884: Add support for the MAX3100 SPI UART.
> 
> i'm not sure whether it has been reported already, but the new 
> driver does not even build:
> 
>    CHK     include/linux/compile.h
>  make[2]: *** No rule to make target `drivers/serial/max3100.o', needed by `drivers/serial/built-in.o'.  Stop.
>  make[1]: *** [drivers/serial] Error 2
>  make[1]: *** Waiting for unfinished jobs....

I hit the same build error just now...

> 
> ... and it has no chance to build, because the commit adds no 
> max3100.c driver file, at all.
> 
> The straight revert of 1dcb884 got the build going.
> 
> 	Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 


-- 
Regards
Yang Hongyang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/