Re: [PATCH v2] tracing/filters: use ring_buffer_discard_commit()in filter_check_discard()

From: Ingo Molnar
Date: Wed Apr 08 2009 - 05:15:00 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> * Ingo Molnar <mingo@xxxxxxx> wrote:
>
> > * Tom Zanussi <tzanussi@xxxxxxxxx> wrote:
> >
> > > This patch changes filter_check_discard() to make use of the new
> > > ring_buffer_discard_commit() function and modifies the current
> > > users to call the old commit function in the non-discard case. It
> > > also introduces a version of filter_check_discard() that uses the
> > > global trace buffer (filter_current_check_discard()) for those
> > > cases.
> > >
> > > v2 changes:
> > >
> > > - fix compile error noticed by Ingo Molnar
> > >
> > > Signed-off-by: Tom Zanussi <tzanussi@xxxxxxxxx>
> >
> > Thanks Tom, i've applied it to tip:tracing/filters and i've started
> > testing it.
>
> still has build failures:
>
> kernel/built-in.o: In function `filter_check_discard':
> trace.c:(.text+0x5b057): undefined reference to `filter_match_preds'

ah, i'll try your other patch as well that separates the event
infrastructre from the event-tracer.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/