Re: [PATCH 51/56] sysv: Remove void casts

[Bert Wesarg]

On Wed, Apr 8, 2009 at 13:22, Jack Stone <jwjstone@xxxxxxxxxxx> wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@xxxxxxxxxxx>
> ---
> Âfs/sysv/dir.c | Â 14 +++++++-------
> Â1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/fs/sysv/dir.c b/fs/sysv/dir.c
> index 56f6552..8a9f5a7 100644
> --- a/fs/sysv/dir.c
> +++ b/fs/sysv/dir.c
> @@ -367,7 +367,7 @@ struct sysv_dir_entry * sysv_dotdot (struct inode *dir, struct page **p)
> Â Â Â Âstruct sysv_dir_entry *de = NULL;
>
> Â Â Â Âif (!IS_ERR(page)) {
> - Â Â Â Â Â Â Â de = (struct sysv_dir_entry*) page_address(page) + 1;
> + Â Â Â Â Â Â Â de = page_address(page) + 1;
This is probably wrong, because (void* + 1) != (struct sysv_dir_entry* + 1).

> Â Â Â Â Â Â Â Â*p = page;
> Â Â Â Â}
> Â Â Â Âreturn de;
> --

Bert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/