Re: [PATCH 50/56] drivers/staging: Remove void casts

[Bert Wesarg]

On Wed, Apr 8, 2009 at 13:22, Jack Stone <jwjstone@xxxxxxxxxxx> wrote:
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@xxxxxxxxxxx>
> ---
> Âdrivers/staging/altpciechdma/altpciechdma.c | Â Â4 ++--
> Âdrivers/staging/epl/EplApiLinuxKernel.c   |  Â8 ++------
> Âdrivers/staging/et131x/et1310_rx.c     Â|  Â2 +-
> Âdrivers/staging/rtl8187se/r8180_core.c   Â|  10 +++++-----
> Âdrivers/staging/slicoss/slicoss.c      |  Â3 +--
> Â5 files changed, 11 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/et131x/et1310_rx.c b/drivers/staging/et131x/et1310_rx.c
> index 8dc559a..4b1ace6 100644
> --- a/drivers/staging/et131x/et1310_rx.c
> +++ b/drivers/staging/et131x/et1310_rx.c
> @@ -610,7 +610,7 @@ int et131x_init_recv(struct et131x_adapter *adapter)
>
> Â Â Â Â/* Setup each RFD */
> Â Â Â Âfor (RfdCount = 0; RfdCount < rx_ring->NumRfd; RfdCount++) {
> - Â Â Â Â Â Â Â pMpRfd = (MP_RFD *) kmem_cache_alloc(rx_ring->RecvLookaside,
> + Â Â Â Â Â Â Â pMpRfd = kmem_cache_alloc(rx_ring->RecvLookaside,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â GFP_ATOMIC | GFP_DMA);
Probably realign this the the opening parentheses, like before.

>
> Â Â Â Â Â Â Â Âif (!pMpRfd) {
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index 6ecd12d..6223371 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -1727,7 +1727,7 @@ short alloc_tx_desc_ring(struct net_device *dev, int bufsize, int count,
> Â Â Â Â Â Â Â ÂDMESGE ("TX buffer allocation too large");
> Â Â Â Â Â Â Â Âreturn 0;
> Â Â Â Â}
> - Â Â Â desc = (u32*)pci_alloc_consistent(pdev,
> + Â Â Â desc = pci_alloc_consistent(pdev,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âsizeof(u32)*8*count+256, &dma_desc);
Please check.

> Â Â Â Âif(desc==NULL) return -1;
> Â Â Â Âif(dma_desc & 0xff){
> @@ -1975,7 +1975,7 @@ short alloc_rx_desc_ring(struct net_device *dev, u16 bufsize, int count)
> Â Â Â Â Â Â Â Âreturn -1;
> Â Â Â Â}
>
> - Â Â Â desc = (u32*)pci_alloc_consistent(pdev,sizeof(u32)*rx_desc_size*count+256,
> + Â Â Â desc = pci_alloc_consistent(pdev,sizeof(u32)*rx_desc_size*count+256,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â&dma_desc);
Probably realign argument.

>
> Â Â Â Âif(dma_desc & 0xff){

Bert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/