Re: [PATCH 20/56] inflate: Remove void casts

From: Jack Stone
Date: Wed Apr 08 2009 - 10:16:24 EST


Will Newton wrote:
> On Wed, Apr 8, 2009 at 2:54 PM, Jack Stone <jwjstone@xxxxxxxxxxx> wrote:
>
>> lib/inflate.c | 5 ++---
>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/inflate.c b/lib/inflate.c
>> index 1a8e8a9..1eb0cd8 100644
>> --- a/lib/inflate.c
>> +++ b/lib/inflate.c
>> @@ -249,7 +249,7 @@ static void *malloc(int size)
>>
>> malloc_ptr = (malloc_ptr + 3) & ~3; /* Align */
>>
>> - p = (void *)malloc_ptr;
>> + p = malloc_ptr;
>> malloc_ptr += size;
>>
>
> Won't this cause a "assignment makes pointer from integer without a
> cast" warning?
I don't think so. The cast had no effect as both malloc_ptr and p are
declared as void *. The later += size
does pointer arithmetic.

Thanks,

Jack
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/