Re: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

[Jeff Kirsher]

On Tue, Apr 7, 2009 at 9:44 PM, Tony Breeds <tony@xxxxxxxxxxxxxxxxxx> wrote:
> GCC warns:
> drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':
> drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
>
> Which I think is right. ÂBracket to remove ambiguity.
>
> Signed-off-by: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>
> ---

Thanks, I will add it to my queue of ixgbe patches.
Remember to CC netdev mailing list for networking patches.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/