Re: [PATCH 51/56] sysv: Remove void casts

From: Jack Stone
Date: Thu Apr 09 2009 - 06:37:34 EST


[Added maintainer CC]
Jack Stone wrote:
> Fixed patch
>
> Thanks,
>
> Jack
>
> --
>
> sysv: Remove void casts
>
> From: Jack Stone <jwjstone@xxxxxxxxxxx>
>
> Remove uneeded void casts
>
> Signed-Off-By: Jack Stone <jwjstone@xxxxxxxxxxx>
> ---
>
> fs/sysv/dir.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/sysv/dir.c b/fs/sysv/dir.c
> index 56f6552..73b70a5 100644
> --- a/fs/sysv/dir.c
> +++ b/fs/sysv/dir.c
> @@ -87,7 +87,7 @@ static int sysv_readdir(struct file * filp, void *
> dirent, filldir_t filldir)
>
> if (IS_ERR(page))
> continue;
> - kaddr = (char *)page_address(page);
> + kaddr = page_address(page);
> de = (struct sysv_dir_entry *)(kaddr+offset);
> limit = kaddr + PAGE_CACHE_SIZE - SYSV_DIRSIZE;
> for ( ;(char*)de <= limit; de++) {
> @@ -157,7 +157,7 @@ struct sysv_dir_entry *sysv_find_entry(struct dentry
> *dentry, struct page **res_
> char *kaddr;
> page = dir_get_page(dir, n);
> if (!IS_ERR(page)) {
> - kaddr = (char*)page_address(page);
> + kaddr = page_address(page);
> de = (struct sysv_dir_entry *) kaddr;
> kaddr += PAGE_CACHE_SIZE - SYSV_DIRSIZE;
> for ( ; (char *) de <= kaddr ; de++) {
> @@ -201,7 +201,7 @@ int sysv_add_link(struct dentry *dentry, struct
> inode *inode)
> err = PTR_ERR(page);
> if (IS_ERR(page))
> goto out;
> - kaddr = (char*)page_address(page);
> + kaddr = page_address(page);
> de = (struct sysv_dir_entry *)kaddr;
> kaddr += PAGE_CACHE_SIZE - SYSV_DIRSIZE;
> while ((char *)de <= kaddr) {
> @@ -244,7 +244,7 @@ int sysv_delete_entry(struct sysv_dir_entry *de,
> struct page *page)
> {
> struct address_space *mapping = page->mapping;
> struct inode *inode = (struct inode*)mapping->host;
> - char *kaddr = (char*)page_address(page);
> + char *kaddr = page_address(page);
> loff_t pos = page_offset(page) + (char *)de - kaddr;
> int err;
>
> @@ -278,7 +278,7 @@ int sysv_make_empty(struct inode *inode, struct
> inode *dir)
> }
> kmap(page);
>
> - base = (char*)page_address(page);
> + base = page_address(page);
> memset(base, 0, PAGE_CACHE_SIZE);
>
> de = (struct sysv_dir_entry *) base;
> @@ -312,7 +312,7 @@ int sysv_empty_dir(struct inode * inode)
> if (IS_ERR(page))
> continue;
>
> - kaddr = (char *)page_address(page);
> + kaddr = page_address(page);
> de = (struct sysv_dir_entry *)kaddr;
> kaddr += PAGE_CACHE_SIZE-SYSV_DIRSIZE;
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/