Re: [PATCH libata: add SSD detection hueristic; move SSD setup toata_dev_configure (was Re: [GIT PULL] Ext3 latency fixes)

From: Tejun Heo
Date: Thu Apr 09 2009 - 14:23:35 EST


Jeff Garzik wrote:
> ata_id_string() or ata_id_c_string() is what you want.
>
> But yeah, we see what you're trying to illustrate.
>
> For internal reasons, it is better to detect and set up SSD details in
> ata_dev_configure(), where we detect and configure other ATA details.
>
> I've attached an example patch, compiled-tested only.
>
> If we wanted to get more fancy, we could extend the strn_pattern_cmp()
> function in libata to accept wildcard '*' prefixes, as well as suffixes.
> That would make it easy to auto-configure future ATA devices based on
> the product id (such as "G.SKILL 128GB SSD").

There was an shell globbing patch floating around which would be
pretty nice to have for pattern matchings like this. cc'ing the patch
author. George, what happened to the patch?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/