Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled
From: Alessandro Zummo
Date: Thu Apr 09 2009 - 18:58:42 EST
On Thu, 9 Apr 2009 15:39:21 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > The rtc_update_irq() might be called with irqs enabled, if a interrupt
> > handler was registered without IRQF_DISABLED.
>
> Why? What are the consequences of not merging the patch? Is it a
> bugfix? If so, what are the user-visible effects of the bug?
rtc_update_irq() is called by a driver, and a driver
is supposed to know when it's doing the call.
The driver can either use IRQF_DISABLED or disable the
interrupts in some other ways.
I also suspect this is some legacy we are carrying on,
so it's better to leave the decision on the interrupt
handling to the driver itself.
Unless I'm missing something.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/