Re: [PATCH] rtc: add x86 support for rtc-efi

From: Ingo Molnar
Date: Fri Apr 10 2009 - 09:51:44 EST



* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, 06 Apr 2009 18:55:49 -0400
> Brian Maly <bmaly@xxxxxxxxxx> wrote:
>
> > re-post of the patch, both as inline and as an attachment (which
> > hopefully wont cause confusion).
> >
>
> Normally it does confuse me horridly because I get two copies of the
> same patch, which applies happily with `patch --dry-run', but dies
> horridly with `patch --for-real'. But I was warned...
>
> In future, please include a full copy of the (possibly modified)
> changelog with each iteration of a patch.
>
> As this patch is mostly-x86 I tossed it onto my for-Ingo pile.
>
>
> From: Brian Maly <bmaly@xxxxxxxxxx>
>
> Add support for rtc-efi (RTC Class Driver for EFI-based systems) to x86.
>
> This patch has been tested and works perfectly on every x86 EFI system I
> could find, though all have been EL64 systems. I would appreciate any
> testing feedback from EL32 systems from anyone that has one and can test.
>
> Signed-off-by: Brian Maly <bmaly@xxxxxxxxxx>
> Acked-by: dann frazier <dannf@xxxxxx>
> Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
> Cc: David Brownell <david-b@xxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> arch/x86/kernel/time_32.c | 19 +++++++++++++++++++
> arch/x86/kernel/time_64.c | 18 ++++++++++++++++++
> drivers/rtc/Kconfig | 2 +-
> 3 files changed, 38 insertions(+), 1 deletion(-)

Hm, it would be nice to first unify the relevant bits of
arch/x86/kernel/time_{32|64}.c into arch/x86/kernel/time.c, and then
we can apply such patches without duplicative effects.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/