Re: [linux-pm] [2.6.30-rc1-git2 regressions] Hibernation broken and(minor but annoying) audio problem

From: Arjan van de Ven
Date: Fri Apr 10 2009 - 21:54:20 EST


Linus Torvalds wrote:

On Fri, 10 Apr 2009, Rafael J. Wysocki wrote:
I've just verified that the resume-after-hibernation issue goes away after
reverting commit 9710794383ee5008d67f1a6613a4717bf6de47bc
(async: remove the temporary (2.6.29) "async is off by default" code) , so it
is async-related.

Arjan? Clearly all the necessary fixes weren't found..

There _is_ a module loading problem wrt initmem - I think you found that and we added a hack for it for the ACPI battery driver. I wonder if we're hitting a similar issue now with module discovery: modules that use "async_schedule()" to do their discovery asynchronously are now not necessarily fully "done" when the module is loaded.

this is both a "yes and no" kind of thing. It already happened for many cases
(USB, SCSI (and thus libata) etc) but now it can happen for more new cases.


And so, anything that expected the devices to be available after module load (like they used to) would be screwed.

IOW, maybe something like the totally untested patch appended here (that should also allow us to make the ACPI battery code to go back to using __init).


this will work. It's a tad unfortunate that we basically end up synchronizing
at load time; maybe some time in the future we can make this opt-in/out ;-(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/