Re: [PATCH] deal with interrupt shadow state for emulated instruction

[H. Peter Anvin]

Avi Kivity wrote:
>>  
>> -    rip = kvm_rip_read(vcpu);
>> -    rip += vmcs_read32(VM_EXIT_INSTRUCTION_LEN);
>> -    kvm_rip_write(vcpu, rip);
>> +    if (!(interruptibility & interruptibility_mask))
>> +        vmcs_write32(GUEST_INTERRUPTIBILITY_INFO,
>> +                 interruptibility | interruptibility_mask);
>> +    vcpu->arch.interrupt_window_open = 0;
>>   
> 
> Setting both _MOV_SS and _STI is wierd; can't happen on real hardware.
> 

Not at architecturally visible boundaries, for sure.  It can be an
implementation artifact internally to an instruction, though.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/