Re: [PATCH 1/1] tracing, workqueuetrace: Make workqueue tracepoints use TRACE_EVENT macro

From: KOSAKI Motohiro
Date: Sun Apr 12 2009 - 23:25:44 EST


> Hi,
>
> hehe, I also have similar patch in my local patch queue ;)
>
> > +TRACE_EVENT(workqueue_insertion,
> > +
> > + TP_PROTO(struct task_struct *wq_thread, struct work_struct *work),
> > +
> > + TP_ARGS(wq_thread, work),
> > +
> > + TP_STRUCT__entry(
> > + __array( char, thread_comm, TASK_COMM_LEN )
> > + __field( pid_t, thread_pid )
> > + __field( struct work_struct *, work )
> > + __field( work_func_t, func )
> > + ),

and, your patch exceed 80 character in many lines.
Please use checkpatch.pl script.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/