Re: [PATCH] tracing: mark get_parent_ip() notrace

From: Lai Jiangshan
Date: Mon Apr 13 2009 - 02:18:54 EST


Frederic Weisbecker wrote:
> On Thu, Apr 02, 2009 at 02:18:25PM +0800, Lai Jiangshan wrote:
>> Impact: remove redundancy tracing log
>>
>> When tracer is "function" or "function_graph", too much
>> "get_parent_ip" are recorded in ring_buffer.
>
>
> Thanks, indeed this get_parent_ip was a bit harrassing
> in the traces, though I still don't understand why it is
> called so often.
>
> Anyway, tracing it seems to me not useful.
>
> Acked-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
>
>

Hi, Ingo,
Could you apply this fix?

get_parent_ip() is a helper function for ftace, and it is called
by preempt_disable() and preempt_enable(), so it is occurred very
often.

Lai.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/