Re: [PATCH]Silencing warning: 'host' may be used uninitialized inthis function

[Jeff Garzik]

Marin Mitov wrote:
> On Friday 10 April 2009 01:38:28 am Jeff Garzik wrote:
> > Marin Mitov wrote:
> > > Hi all,
> > >
> > > I do not know if that is worth the effort, but...
> > >
> > > Silencing:  warning: 'host' may be used uninitialized in this function
> > > It is a false positive.
> > >
> > > The patch is against 2.6.30-rc1, but should apply to 2.6.29(.1) too.
> > >
> > > Signed-off-by: Marin Mitov mitov@xxxxxxxxxxx
> > > ================================================
> > > --- a/drivers/ata/sata_via.c	2009-04-05 22:59:26.000000000 +0300
> > > +++ b/drivers/ata/sata_via.c	2009-04-06 00:07:25.000000000 +0300
> > > @@ -566,7 +566,7 @@
> > >  	static int printed_version;
> > >  	unsigned int i;
> > >  	int rc;
> > > -	struct ata_host *host;
> > > +	struct ata_host *host = host;
> > >  	int board_id = (int) ent->driver_data;
> > >  	const unsigned *bar_sizes;
> > we use the uninitialized_var() macro for false positives.
> >
> > 	Jeff
>  
> Well, changed and resubmitted.
>
> Marin Mitov
>
> Silencing: " warning: 'host' may be used uninitialized in this function"
>
> The patch is against 2.6.30-rc1, but should apply to 2.6.29(.1) too.
>
> Signed-off-by: Marin Mitov mitov@xxxxxxxxxxx
> ================================================
> --- a/drivers/ata/sata_via.c	2009-04-05 22:59:26.000000000 +0300
> +++ b/drivers/ata/sata_via.c	2009-04-06 00:07:25.000000000 +0300
> @@ -566,7 +566,7 @@
>  	static int printed_version;
>  	unsigned int i;
>  	int rc;
> -	struct ata_host *host;
> +	struct ata_host *uninitialized_var(host);
>  	int board_id = (int) ent->driver_data;
>  	const unsigned *bar_sizes;

I did this a slightly different way...  I went ahead and simply 
initialized it.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/