Re: bug in drivers/edac/mpc85xx_edac.c:mpc85xx_mc_check() ?

[Dave Jiang]

Jeff, you are correct. I will submit a patch to correct that.

Andrew Morton wrote:
> (cc's added)
>
> On Wed, 8 Apr 2009 14:57:42 -0700
> "Jeff Haran" <jharan@xxxxxxxxxxx> wrote:
>
> > Hi,
> >
> > Recent versions of this function start off with:
> >
> > static void mpc85xx_mc_check(struct mem_ctl_info *mci)
> > {
> >     struct mpc85xx_mc_pdata *pdata = mci->pvt_info;
> >     ...
> >
> >     err_detect = in_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT);
> >     if (err_detect)
> >         return;
> >
> >     ...
> > }
> >
> > My reading of the Freescale 8548E Manual leads me to conclude that the
> > Memory Error Detect register (ERR_DETECT) will have various bits set if
> > the memory controller has detected an error since the last time it was
> > cleared. If no memory error has occurred, the register will contain 0.
> >
> > Perhaps I am missing something very basic, but it seem to me that the
> > above "if" should be:
> >
> >     if (!err_detect)
> >         return;
> >
> > as the existing code would seem to read "if any errors have occurred,
> > ignore them", though perhaps testing has demonstrated that the Freescale
> > manual is in error.
> >
> > Please include this email address in responses as I do not subscribe.
> >
> > Thanks,
> >
> > Jeff Haran
> > Brocade


--

------------------------------------------------------
Dave Jiang
Software Engineer
MontaVista Software, Inc.
http://www.mvista.com
------------------------------------------------------

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/