Re: [PATCH] slow_work_thread() should do the exclusive wait

From: David Howells
Date: Mon Apr 13 2009 - 17:35:57 EST


Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> slow_work_thread() sleeps on slow_work_thread_wq without WQ_FLAG_EXCLUSIVE,
> this means that slow_work_enqueue()->__wake_up(nr_exclusive => 1) wakes up
> all kslowd threads. Afaics this is not what we want, change slow_work_thread()
> to use prepare_to_wait_exclusive().

Hmmm... I think you may be right. I think I was assuming that wake_up()
would only wake up the first item on the queue, but that's not strictly what
it does...

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/