Re: [PATCH 3/4] [MTD] compat_ioctl cleanup

[Arnd Bergmann]

On Thursday 09 April 2009, Kevin Cernekee wrote:

>   Â
> 1) Move the MEMREADOOB/MEMWRITEOOB compat_ioctl wrappers from
> fs/compat_ioctl.c into mtdchar.c . ÂOriginal request was here:
> 
> http://lkml.org/lkml/2009/4/1/295

Very nice cleanup, thanks for doing this!

> 2) Add missing COMPATIBLE_IOCTL lines, so that mtd-utils does not error
> out when running in 64/32 compatibility mode.

This looks correct, but I think it would be better to just remove all
those lines from fs/compat_ioctl.c and add a default: statement in
mtd_compat_ioctl that calls mtd_ioctl for all ioctl numbers that
don't have an explicit handler.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/