Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()

[Linus Torvalds]

On Tue, 14 Apr 2009, David Howells wrote:
> 
> Agreed, it would be nice.  However, x86 requires it to be declared in the
> middle of asm/percpu.h (ie: in asm-generic/percpu.h). 

Hmm. Why not move it all above the '#include <asm/percpu.h>'?

Sure, then the odd architectures (read: ia64) that actually want to 
re-define things like PER_CPU_BASE_SECTION would have to now do

	#undef PER_CPU_BASE_SECTION
	#define PER_CPU_BASE_SECTION ".data.percpu"

but wouldn't that all actually be much CLEANER than the insane crap we do 
today?

But yeah, I didn't look at all the details. It _looked_ pretty 
straightforward to just move the DEFINE/DECLARE stuff up, but there may 
well be something subtle I'm missing.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/