Re: [RFC][PATCH v3 2/6] mm, directio: fix fork vs direct-io race(read(2) side IOW gup(write) side)

From: Andrea Arcangeli
Date: Tue Apr 14 2009 - 15:50:14 EST


On Tue, Apr 14, 2009 at 02:10:08PM -0400, Jeff Moyer wrote:
> Really? I don't actually see that in the code, have I missed it?

Checking the spinlock version, when any writer is waiting, the
sem->wait_list won't empty and down_read will wait too. The wakeup is
FIFO with __rwsem_do_wake is doing a wake-one if first one in queue is
a down_write. So it looks ok to me. asm version should have an
equivalent logic.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/