Re: [PATCH] tracing/filters: allow on-the-fly filter switching

[Frederic Weisbecker]

On Wed, Apr 15, 2009 at 09:12:58AM +0800, Li Zefan wrote:
> > Ok, the whole design and concept looks nice.
> > 
> > But you really need to think about a locking scheme to protect
> > the filters from user files.
> > 
> 
> I noticed this and fixed it in that
> 	"[PATCH 7/7] tracing/filters: make filter preds RCU safe"
> 
> I'll try to fix it on top of Tom's on-the-fly filter swithcing,
> if Tom hasn't started to do this.


Ah, ok.

Thanks.

 
> > Also, is filter_add_pred() supposed to be available for in-kernel
> > uses by other tracers or something?
> > If this is planned, the locking could be even deeper than my comments.
> > 
> > Other than these comments:
> > 
> > Acked-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > 
> > Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/