Re: Fix quilt merge error in acpi-cpufreq.c

[Linus Torvalds]

On Wed, 15 Apr 2009, H. Peter Anvin wrote:
> 
> "cleanup" is indeed the most common, as it is intended to signify a
> trivial but nonzero code change.  Whether or not it's *correct* is
> another matter.  "build fix" is valid and proper use: it tells that it
> fixes a compilation error, which succinctly communicates both the
> priority of the fix and how it needs to be validated.

Why would that be "proper use"?

Dammit, if the "build fix" is not obvious from the rest of the commit 
message, there's something wrong.

And if it _is_ obvious, then the mechanical "Impact:" thing is pointless.

In other words - in neither case does it actually help anything at all. 
It's only distracting noise.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/