Re: Fix quilt merge error in acpi-cpufreq.c

From: Valdis . Kletnieks
Date: Thu Apr 16 2009 - 10:23:28 EST


On Wed, 15 Apr 2009 14:23:26 PDT, David Miller said:
> From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 15 Apr 2009 12:43:02 -0700 (PDT)
>
> > And if it _is_ obvious, then the mechanical "Impact:" thing is pointless.
> >
> > In other words - in neither case does it actually help anything at all.
> > It's only distracting noise.
>
> FWIW I find the Impact: blurbs highly annoying too. Just freakin'
> say what the damn patch does in the commit message.
>
> If a person can't be bothered to skim the commit message text,
> this Impact: tag only gives them a false sense of understanding
> what the change does.

Maybe we can use it to flag security fixes, to appease the people complaining
they can't find the security fixes without reading the commit message text. ;)

Attachment: pgp00000.pgp
Description: PGP signature