Re: [PATCH 5/5] tracing: add saved_cmdlines file to show cached taskcomms

From: Steven Rostedt
Date: Thu Apr 16 2009 - 12:02:04 EST



On Thu, 16 Apr 2009, Frederic Weisbecker wrote:

> On Wed, Apr 15, 2009 at 10:18:35PM -0400, Steven Rostedt wrote:
> > From: Avadh Patel <avadh4all@xxxxxxxxx>
> >
> > Export the cached task comms to userspace. This allows user apps to translate
> > the pids from a trace into their respective task command lines.
>
>
> Hi,
>
> I don't understand why this is needed. The pid is already resolved
> to its task comm into the trace.

Nope, it is not. The trace buffer does not hold the comm. It is in an
internal cache within ftrace. This exports this table.

>
> Or is there another reason?

If you were to perform a trace, and then stop it. Only the pids are in the
trace buffer. If those processes end, there's no way to find out what
process were attached to those pids. This table maps the pids in the
buffer to the comms saved in the cache. As long as you don't run another
trace, the cache will hold the pids in the trace.

Note, this is for reading the binary data files.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/