Re: [PATCH RFC] ext3 data=guarded v3

From: Nick Piggin
Date: Thu Apr 16 2009 - 14:09:25 EST


On Thursday 16 April 2009 06:35:23 Linus Torvalds wrote:
>
> On Wed, 15 Apr 2009, Chris Mason wrote:
> >
> > Here is another version of the data=guarded work for ext3. The main
> > difference between this code and yesterday's is the guarded writepage
> > function now sends any newly allocated block through the old data=ordered code.
>
> I'm inclined to apply the first two patches as infrastructure, since they
> seem to make sense regardless of data=ordered. The ability to get a
> callback when IO ends sounds like something that a number of cases might
> find intriguing, and it's obviously how the actual IO has worked
> internally anyway.
>
> Comments?

I think also fscache really should be using proper read completed notifications
rather than hijacking the page lock waitqueue for this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/