Re: [PATCH 4/8] irq: only update affinity in chip set_affinity()-v3

From: Suresh Siddha
Date: Thu Apr 16 2009 - 19:27:05 EST


On Wed, 2009-04-15 at 18:41 -0700, Yinghai Lu wrote:
> Impact: keep affinity consistent
>
> irq_set_affinity() and move_masked_irq() try to assign affinity
> before calling chip set_affinity(). some archs are assigning again in set_affinity
> again.
>
> something like:
> cpumask_cpy(desc->affinity, mask);
> desc->chip->set_affinity(mask);
>
> in the failing path, affinity should not be touched.
>
> also set_extra_move_desc() ( called by set_affinity) will rely on the old
> affinity to decide if need to move irq_desc to different node when logical
> flat apic mode is used.
>
> So try remove those assignment, and make some missed arch to assign affinity
> in their set_affinity.
>

I don't see any arch specific changes in this patchset regarding this.
Did I miss or currently there are no arch's that needs to get fixed?

thanks,
suresh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/