Re: [PATCH] tracing/filters: add filter_mutex to protect filterpredicates

[Ingo Molnar]

* Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:

> Tom Zanussi wrote:
> > This patch adds a filter_mutex to prevent the filter predicates from
> > being accessed concurrently by various external functions.
> > 
> > It's based on a previous patch by Li Zefan:
> >         "[PATCH 7/7] tracing/filters: make filter preds RCU safe"
> > 
> > but any problems with it were added by me. ;-)
> > 
> > Signed-off-by: Tom Zanussi <tzanussi@xxxxxxxxx>
> > 
> 
> Reviewed-and-tested-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
> 
> except:
> 
> > @@ -348,17 +399,15 @@ int filter_add_subsystem_pred(struct event_subsystem *system,
> >  		if (strcmp(call->system, system->name))
> >  			continue;
> >  
> > -		if (!find_event_field(call, pred->field_name))
> > -			continue;
> > -
> > -		err = filter_add_pred(call, pred);
> > +		err = __filter_add_pred(call, pred);
> >  		if (err == -ENOMEM) {
> >  			system->preds[system->n_preds] = NULL;
> > -			return err;
> > +			system->n_preds--;
> > +			break;
> 
> now we return 0 but not ENOMEM in this failure case.

ok - i'll wait for this fix.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/