Re: [PATCH] v3 fix error on drivers/ata/pata_legacy.c

From: Jeff Garzik
Date: Fri Apr 17 2009 - 06:42:17 EST


Alan Cox wrote:
On Fri, 17 Apr 2009 15:32:59 +0800
Zhenwen Xu <helight.xu@xxxxxxxxx> wrote:

fix those errors:

drivers/ata/pata_legacy.c: In function âpdc_data_xfer_vlbâ:
drivers/ata/pata_legacy.c:289: error: âapâ undeclared (first use in this function)
drivers/ata/pata_legacy.c:289: error: (Each undeclared identifier is reported only once
drivers/ata/pata_legacy.c:289: error: for each function it appears in.)
drivers/ata/pata_legacy.c: At top level:
drivers/ata/pata_legacy.c:869: error: âATA_PFLAG_PIO32_CHANGEâ undeclared here (not in a
+function)
make[2]: *** [drivers/ata/pata_legacy.o] Error 1
make[1]: *** [drivers/ata] Error 2

Looks good to me. I shall have to find something larger than PROPOSED in
the patch title to stop Jeff applying things that were discussion code

It had a 'signed-off-by', which I took to mean, it was a proposed patch that was OK to merge once people were happy... Sorry about that misinterpretation.

Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/