Re: [PATCH 5/5] x86: fix x2apic/intr-remap resume

[Ingo Molnar]

* Weidong Han <weidong.han@xxxxxxxxx> wrote:

>  #ifdef CONFIG_INTR_REMAP
> -	if (intr_remapping_enabled)
> -		reenable_intr_remapping(EIM_32BIT_APIC_ID);
> +	if (intr_remapping_enabled) {
> +		if (x2apic)
> +			reenable_intr_remapping(EIM_32BIT_APIC_ID);
> +		else
> +			reenable_intr_remapping(EIM_8BIT_APIC_ID);

ok, we had this sequence before. Might be worthwile to push the 
x2apic condition into reenable_intr_remapping() itself? That would 
simplify the call sites.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/