Re: IMA and fs

From: Mimi Zohar
Date: Fri Apr 17 2009 - 14:20:35 EST


hooanon05@xxxxxxxxxxx wrote on 04/17/2009 09:57:46 AM:

> Mimi Zohar:
> > > xfs_iget() holds spinlock before xfs_iget_cache_hit(), and
> > > ima_inode_alloc() cannot use GFP_KERNEL.
> >
> > This looks similar to the xfs - IMA problem discussed
> > http://lkml.org/lkml/2009/2/20/327.
>
> Yes, the same issue.
> I didn't know it was discussed before.
> So what is the conclusion? Are you waiting for fixing the spinlock in
> xfs?

Yes. I just assumed, incorrectly, the xfs maintainer was notified.
Am copying the xfs maintainer now.

> > > Does nfsd_open() need to to call ima_path_check()?
> :::
> > Yes, in order for the open/free to be balanced in ima_file_free().
>
> Then how about putting ima_path_check() into __dentry_open() instead of
> may_open()?
>
>
> J. R. Okajima

Interesting. Am looking into it.

Thanks!

Mimi Zohar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/